Fix bug in beta value computation #8466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Beta is fill-forwarded - A correct pair considered when they have different symbols and the same date - Processing occurs when there are at least period+1 correct pairs
JosueNina
force-pushed
the
bug-8460-beta-indicator-stuck-at-zero
branch
from
1d09f84 to
bbb4ec0
Compare
JosueNina
force-pushed
the
bug-8460-beta-indicator-stuck-at-zero
branch
from
2485e58 to
834cff7
Compare
- Remove effectiveResolution and Beta constructor parameter for resolution. - Streamlined resolution handling logic for Beta indicator. - Fixed issues with regression test for Beta.
JosueNina
force-pushed
the
bug-8460-beta-indicator-stuck-at-zero
branch
from
d17fd8d to
6c03643
Compare
JosueNina
force-pushed
the
bug-8460-beta-indicator-stuck-at-zero
branch
from
a422ce7 to
b35326c
Compare
JosueNina
force-pushed
the
bug-8460-beta-indicator-stuck-at-zero
branch
from
5496967 to
f1d8657
Compare
JosueNina
force-pushed
the
bug-8460-beta-indicator-stuck-at-zero
branch
from
f1d8657 to
83117a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in the beta calculation logic. It ensures that the beta value is calculated correctly by processing data only when enough pairs of different symbols with the same date are available. Additionally, it now processes when at least "period + 1" correct pairs are available. The beta value is "fill-forwarded" until a valid pair is found, at which point it recalculates the beta.
Related Issue
Closes #8460
Motivation and Context
This change is required to ensure that the beta calculation logic works correctly and efficiently,
Requires Documentation Change
No documentation change required.
How Has This Been Tested?
It has been tested both in the cloud and locally. Additionally, a unit test has been added to ensure the correct functionality of the beta calculation. The test verifies that the logic correctly handles symbol pairs, computes the beta value, and processes the data only when enough valid pairs are available.
Types of changes
Checklist:
bug-<issue#>-<description>orfeature-<issue#>-<description>